Add documentation for openvox-strings #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silug
force-pushed
the
strings
branch
2 times, most recently
from
1ccaee6 to
c021bc7
Compare
jay7x
reviewed
Jul 8, 2025
jay7x
reviewed
Jul 8, 2025
| Array[String[1]] $slaves, | ||
| Stdlib::Ensure::Package $ensure = present, | ||
| Optional[Stdlib::IP::Address::V4] $ipaddress = undef, | ||
| Optional[String[1]] $netmask = undef, |
Member
There was a problem hiding this comment.
This can be Stdlib::IP::Address::Nosubnet also, I guess.. though not 100% sure. For ipv4 the mask is just an IP address at least.
Contributor
Author
There was a problem hiding this comment.
Good catch. That should not be IPv4-only.
Member
There was a problem hiding this comment.
Here I meant that $netmask can be validated against Stdlib::IP::Address::Nosubnet (at least for IPv4, need to recheck for IPv6, but I believe it's the same). Though, I can accept String[1] for now also.
Also add data types to `class` and `define` definitions.
jay7x
reviewed
Jul 8, 2025
jay7x
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Also add data types to
classanddefinedefinitions.This Pull Request (PR) fixes the following issues
N/A