feat: add support for gentoo (#37)#39
Conversation
| } | ||
| 'Debian', 'RedHat', 'Suse': { | ||
| 'Debian', 'RedHat', 'Suse', 'Gentoo': { | ||
| $puppetserver_package = 'openvox-server' |
There was a problem hiding this comment.
I'm not a Puppet expert at all, I'm just here as a Gentoo person and also someone who is slowly learning Puppet ropes for Gentoo infra: are you sure this part is right? In Gentoo, packages have categories, so normally you would want app-admin/openvox-server or something, but I am not sure how this value is used here.
It also might be worth holding off (can still get it ready of course, just maybe keep it as a draft?) until we have it in ::gentoo, because otherwise the category and package name are subject to change.
|
cc @anthonyryan1 @alarig (and @robbat2) |
|
I'm AFK for the moment, returning to the office on May 4th. I'm not familiar with this component, but I can become familiar if it's useful for other Gentoo puppet users (the more users, the more likely it doesn't bitrot on us. I'll loop back into this issue early that week. |
3 participants
Pull Request (PR) description
This pull request add support for Gentoo to the module closing #37.
It is my first contribution to a puppet module, feel free to guide or correct me if you think it can be improved.
Thank you again for all your work :) !
This Pull Request (PR) fixes the following issues
Fixes #37