Actually use puppetdb_version set as class parameters

[XMol]

Pull Request (PR) description

Properly solve the issue reported through #46 (#47 was closed, not merged).

This Pull Request (PR) fixes the following issues

Fixes #46 (even though that is already closed)

Sidenote

I have not changed the parameter defaults for openvoxdb::server, they still all fall back to openvoxdb::params. Though this paradigm is open for Puppet's automatic parameter lookup, which was broken at least for the openvoxdb package resource, by also using the value from params.pp.

[XMol]

Ah, there is another open point here: openvoxdb::master::config also references $openvoxdb::params::puppetdb_version in order to install the appropriate openvoxdb-termini package.

Here we cannot use the real parameter value of openvoxdb::server, since that class might not be included in the catalog. For the same reason, $openvoxdb::puppetdb_version might be unset. The best option in my humble opinion is to add another paramater to openvoxdb::master::config, e.g. terminus_package_version, seeing that $openvoxdb::master::config::terminus_package already exists - I'll push a commit for that right away.

[XMol]

I'll try to resolve the CI errors tomorrow...

[XMol]

OK, this took me some time, since I don't have a Puppet development environment, certainly not one with all the voxpupuli requirements satisfied. But with voxbox this still was rather easy.

I still kept two commits after squashing, one addresses the bug from the original motivation. The second one fixes the same bug in a different manifest (openvoxdb::master::config). I chose to introduce a new parameter for that secondary fix, which you might appreciate isolated in its own commit. Please, just tell me whether you prefer all commits squashed together in one, then of course do that. Otherwise, I consider the PR ready for revision.

[d1nuc0m]

The issue seems valid, CC @giacomd as he's also interested.

Tbh params.pp should be gone at all, but didn't have time to refactor the module at time. Having separate parameters for terminus and DB is ok, there might be use cases for that I guess