Skip to content

feat(providers): Add support for array DCS values - #82

Open
jonasdemoor wants to merge 3 commits into
voxpupuli:mainfrom
UGent-DICT:dcs_array_values
Open

jonasdemoor wants to merge 3 commits into
voxpupuli:mainfrom
UGent-DICT:dcs_array_values

Conversation

@jonasdemoor

Copy link
Copy Markdown

Pull Request (PR) description

This PR adds support for handling array config values (e.g. postgresql.pg_hba). I'm not sure if this is the best way to do it, but it's the only way I found to be working, while still supporting non-array values.

This Pull Request (PR) fixes the following issues

n/a

@bluthg

bluthg commented Aug 7, 2025

Copy link
Copy Markdown

I'm quite sure that a simple Patroni reload is sufficient to activate changes in the pg_hba part.

@jonasdemoor

Copy link
Copy Markdown
Author

I'm quite sure that a simple Patroni reload is sufficient to activate changes in the pg_hba part.

Hi, you're correct, I tested this and only the pg_hba changes in the YAML config file are taken into account; the pg_hba changes in DCS are ignored.

pg_hba is listed in the DCS docs though: https://patroni.readthedocs.io/en/latest/dynamic_configuration.html#dynamic-configuration

@bluthg

bluthg commented Aug 13, 2025

Copy link
Copy Markdown

Hmmm... TBTH, I was pointed here by @lbetz and only just read what provider/patroni_dcs_config/patronictl.rb actually does 🙈
In my experience, patronictl knows by itself when to propagate what and how. So if it doesn't do so in this case, something else is probably wrong.
Are you positive that you're changing the pg_hba entry of the ^postgresql: part? Not the one in the ^bootstrap: part?

@bastelfreak

Copy link
Copy Markdown
Member

@jonasdemoor can you take another look here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants