Skip to content

Add more OSes, refactor acceptance tests#283

Merged
jay7x merged 5 commits into
masterfrom
acceptance_rfc
Jun 18, 2026
Merged

Add more OSes, refactor acceptance tests#283
jay7x merged 5 commits into
masterfrom
acceptance_rfc

Conversation

@jay7x

@jay7x jay7x commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR has acceptance tests refactored. That allows to support more OSes:

  • AlmaLinux 8/9
  • Debian 11/12/13
  • OracleLinux 9
  • Rocky 8/9,
  • Ubuntu 22.04/24.04

@jay7x

jay7x commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Tested this on:

  • Ubuntu 22.04, 24.04
  • Debian 11, 12, 13 (See NOTE below)
  • Rocky 9
  • AlmaLinux 9
  • OracleLinux 8, 9

It doesn't work on RHEL10-alikes by 2 reasons:

  1. There is no support for RHEL-10 in the upstream repo (http://rpms.adiscon.com/v8-stable has no rhel-10 yet)
  2. There is either bug or feature that breaks wipe_rsyslog() helper: https://gist.github.com/jay7x/e22bad9544eef71fcf28866921f29b75. Though, I'll workaround this later.

NOTE: Debian is in a gray area at the moment. There are no official upstream builds of recent rsyslog version. There is OBS repo that has 8.2512 as latest version. I'm not sure if we should support that or wait for any clarification on Debian status (See rsyslog/rsyslog#6767). So far upstream repo is not enabled and the corresponding acceptance test is skipped.

@jay7x

jay7x commented May 4, 2026

Copy link
Copy Markdown
Member Author

One dropped part is a test with keeping existing OS rsyslog config. I have mixed feelings here. My idea is that we're testing the module, not the OS. I'd prefer maybe to introduce OS-specific default configs instead.

@kenyon

kenyon commented May 10, 2026

Copy link
Copy Markdown
Member

Looks good so far 👍

@jay7x
jay7x marked this pull request as ready for review June 16, 2026 07:00
@jay7x

jay7x commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

CentOS 9 hits the same issue as I saw on Alma 10. See https://gist.github.com/jay7x/e22bad9544eef71fcf28866921f29b75. Will see how to deal with it..

@jay7x
jay7x marked this pull request as draft June 16, 2026 09:13
@jay7x

jay7x commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

The failure above was in the cleanup helper, so can be just ignored. Though, now it fails, because test expects a package to be installed from the upstream rsyslog repository. But CentOS 9 is fast enough to have the same version in appstream, which is preferred over the upstream_rsyslog one.. 🤔

jay7x added 4 commits June 17, 2026 07:29
@jay7x
simplify init.pp a bit
4fe73e7 
Signed-off-by: Yury Bushmelev <jay4mail@gmail.com>
@jay7x
specify missing ppa -> package dependency
3746b9b 
Signed-off-by: Yury Bushmelev <jay4mail@gmail.com>
@jay7x
refactor acceptance tests
595602d 
Signed-off-by: Yury Bushmelev <jay4mail@gmail.com>
@jay7x
increase upstream repo priority
13e50ad 
Signed-off-by: Yury Bushmelev <jay4mail@gmail.com>
@jay7x jay7x self-assigned this Jun 16, 2026
@jay7x jay7x added the enhancement New feature or request label Jun 16, 2026
@jay7x
jay7x marked this pull request as ready for review June 16, 2026 23:48
@jay7x jay7x changed the title Refactor acceptance tests Add more OSes, refactor acceptance tests Jun 16, 2026
@jay7x
jay7x requested review from bastelfreak and kenyon June 16, 2026 23:51
@jay7x

jay7x commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

I decided to add more OSes right here to see tests are good for all of them.

kenyon
kenyon reviewed Jun 16, 2026
View reviewed changes

@kenyon kenyon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We could also add Ubuntu 26.04.

Comment thread metadata.json
"operatingsystemrelease": []
"operatingsystem": "Ubuntu",
"operatingsystemrelease": [
"18.04",

@kenyon kenyon Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18.04 is EOL.

Suggested change
"18.04",

@jay7x jay7x Jun 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be considered backward-incompatible, right? I'd prefer to drop outdated OSes in another PR (after a release ideally).

Comment thread metadata.json
{
"operatingsystem": "Debian",
"operatingsystemrelease": [
"11",

@kenyon kenyon Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 is EOL.

Suggested change
"11",

@jay7x jay7x Jun 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need it :-D Let's do one release with Debian 11 supported and then drop it.

@jay7x
jay7x merged commit b3f3162 into master Jun 18, 2026
15 checks passed
@jay7x
jay7x deleted the acceptance_rfc branch June 18, 2026 09:53
@jay7x jay7x mentioned this pull request Jun 18, 2026
Closed
This was referenced Jun 18, 2026
Closed
Open
Closed
legooolas
legooolas reviewed Jul 16, 2026
View reviewed changes
Comment thread metadata.json
},
{
"operatingsystem": "Ubuntu",
"operatingsystem": "RedHat",

@legooolas legooolas Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have dropped RHEL8 -- is that intentional?

@jay7x jay7x Jul 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. I don't think so.. please add it back in another PR

@legooolas legooolas Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenyon kenyon kenyon approved these changes
@bastelfreak bastelfreak bastelfreak approved these changes
+1 more reviewer
@legooolas legooolas legooolas left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jay7x jay7x

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jay7x @kenyon @bastelfreak @legooolas