Fix #391: Allow package_ensure => latest on Windows with Chocolatey provider

[raman1236]

Pull Request (PR) description

This PR fixes issue #391 by allowing package_ensure => 'latest' on Windows when using Chocolatey as the package provider.

Changes Made

• Modified validation logic in manifests/forwarder.pp and manifests/enterprise.pp
• The validation now only fails when OS is Windows AND package_ensure is 'latest' AND package_provider is NOT 'chocolatey'
• Updated error message to guide users to use Chocolatey when they want to use ensure => latest on Windows

Rationale

As mentioned in #391, Chocolatey supports package upgrades, making it possible to use ensure => latest on Windows. The previous implementation blocked this functionality entirely based solely on the OS family, preventing legitimate use cases where Chocolatey is used as the package provider.

Example Usage

Users can now successfully use:

class { 'splunk::forwarder':
  package_ensure   => 'latest',
  package_provider => 'chocolatey',
}

Backward Compatibility

• Changes maintain full backward compatibility
• Still fails appropriately for non-Chocolatey providers on Windows (like MSI)
• No impact on non-Windows systems

This Pull Request (PR) fixes the following issues

Fixes #391