-
-
Notifications
You must be signed in to change notification settings - Fork 240
CI: Test if we can build puppetboard & install setuptools #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
=======================================
Coverage 76.92% 76.92%
=======================================
Files 20 20
Lines 1309 1309
=======================================
Hits 1007 1007
Misses 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we need to declare setuptools as a dependency in some way. Or migrate to pyproject.toml
. https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ says we can declare setuptools as the build system:
[build-system]
requires = ["setuptools >= 61.0"]
build-backend = "setuptools.build_meta"
No idea if we really need >= 61.0
or any version.
.github/workflows/tests.yml
Outdated
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [3.9, '3.10', 3.11, 3.12, 3.13] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always a fan of the multi-line version so you can easily add and remove lines with a readable diff
I do not know enough about python. |
In our normal test pipeline, we didn't verify if we can properly build the package. because of that, the last 6.0.0 release failed: ``` Run python setup.py build sdist bdist_wheel Traceback (most recent call last): File "/home/runner/work/puppetboard/puppetboard/setup.py", line 3, in <module> from setuptools.command.test import test as TestCommand ModuleNotFoundError: No module named 'setuptools' ```
In our normal test pipeline, we didn't verify if we can properly build the package. because of that, the last 6.0.0 release failed: