-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for puppetfile resolver #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
logicminds
wants to merge
2
commits into
master
Choose a base branch
from
puppetfile_resolver
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'puppetfile-resolver' | ||
require 'puppetfile-resolver/puppetfile/parser/r10k_eval' | ||
|
||
module Ra10ke | ||
# puppetfile-resolver tasks | ||
module Resolver | ||
def define_task_resolver(*_args) | ||
desc 'Run the puppetfile Resolver' | ||
task :resolver do | ||
resolver = Ra10ke::Resolver::Instance.new(get_puppetfile.puppetfile_path) | ||
result = resolver.resolve | ||
# Output resolution validation errors | ||
result.validation_errors.each { |err| puts "Resolution Validation Error: #{err}\n" } | ||
end | ||
end | ||
|
||
# Instance class | ||
class Instance | ||
attr_reader :puppetfile | ||
|
||
def initialize(puppetfile_path = File.expand_path(Dir.pwd)) | ||
# Parse the Puppetfile into an object model | ||
content = File.binread(puppetfile_path) | ||
|
||
@puppetfile = ::PuppetfileResolver::Puppetfile::Parser::R10KEval.parse(content) | ||
|
||
# Make sure the Puppetfile is valid | ||
return if puppetfile.valid? | ||
|
||
puts 'Puppetfile is not valid' | ||
puppetfile.validation_errors.each { |err| puts err } | ||
exit 1 | ||
end | ||
|
||
def resolve | ||
# Create the resolver | ||
# - Use the document we just parsed (puppetfile) | ||
# - Don't restrict by Puppet version (nil) | ||
resolver = ::PuppetfileResolver::Resolver.new(puppetfile, nil) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an attr_reader for puppetfile |
||
|
||
# Configure the resolver | ||
cache = nil # Use the default inmemory cache | ||
ui = nil # Don't output any information | ||
module_paths = [] # List of paths to search for modules on the local filesystem | ||
allow_missing_modules = true # Allow missing dependencies to be resolved | ||
opts = { cache: cache, ui: ui, module_paths: module_paths, allow_missing_modules: allow_missing_modules } | ||
|
||
# Resolve | ||
resolver.resolve(opts) | ||
end | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'spec_helper' | ||
require 'ra10ke/resolver' | ||
RSpec::Mocks.configuration.allow_message_expectations_on_nil = true | ||
|
||
RSpec.describe 'Ra10ke::Resolver::Instance' do | ||
include Ra10ke::Resolver | ||
let(:instance) do | ||
Ra10ke::Resolver::Instance.new(puppetfile) | ||
end | ||
|
||
let(:puppetfile) do | ||
File.join(fixtures_dir, 'Puppetfile') | ||
end | ||
|
||
it 'resolves the puppetfile' do | ||
expect(instance.resolve).to be_nil | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a directory, not a file? Cant read a dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. why yes that would fail.