-
Notifications
You must be signed in to change notification settings - Fork 11
feat: update ruby (3.2/3.1) and rubocop (1.81.1) #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a786b14
e799c0f
2ff5bde
6ed16a6
83e4828
69a8113
e3af267
6c114a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| # This is a shared config for easy consumption in other modules, without having | ||
| # to sync over a large file | ||
| require: | ||
| plugins: | ||
| - rubocop-rspec | ||
| - rubocop-rake | ||
|
|
||
| AllCops: | ||
| # Puppetserver 7 uses Jruby 9.3 which is compatible to C Ruby 2.6 | ||
| TargetRubyVersion: 2.6 | ||
| # OpenVox Server 8 uses JRuby 9.4 which is compatible to MRI Ruby 3.1 | ||
| TargetRubyVersion: 3.1 | ||
| DisplayCopNames: true | ||
| ExtraDetails: true | ||
| DisplayStyleGuide: true | ||
|
|
@@ -445,10 +445,13 @@ Style/PercentLiteralDelimiters: | |
| Style/PerlBackrefs: | ||
| Enabled: True | ||
|
|
||
| Naming/PredicateName: | ||
| Naming/PredicatePrefix: | ||
| Enabled: True | ||
| AllowedMethods: ['is_a?', 'is_to_s'] | ||
|
|
||
| Naming/PredicateMethod: | ||
| Enabled: false | ||
|
|
||
| Style/RedundantException: | ||
| Enabled: True | ||
|
|
||
|
|
@@ -557,7 +560,12 @@ Style/FormatStringToken: | |
|
|
||
| # This is useful, but sometimes a little too picky about where unit tests files | ||
| # are located. | ||
| RSpec/FilePath: | ||
|
|
||
| # old cop: RSpec/FilePath | ||
| RSpec/SpecFilePathFormat: | ||
| Enabled: false | ||
|
|
||
| RSpec/SpecFilePathSuffix: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we please keep this enabled? It avoids situations like puppetlabs/puppetlabs-postgresql#1633 and puppetlabs/puppetlabs-postgresql#1634. It was actually the
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can do, just disabled it, as the "original" it was splitted from was also disabled. |
||
| Enabled: false | ||
|
|
||
| # Leaving these enabled creates too much busy work | ||
|
|
@@ -662,8 +670,6 @@ RSpec/IdenticalEqualityAssertion: # new in 2.4 | |
| Enabled: true | ||
| RSpec/SubjectDeclaration: # new in 2.5 | ||
| Enabled: true | ||
| RSpec/Rails/AvoidSetupHook: # new in 2.4 | ||
| Enabled: true | ||
| RSpec/ImplicitSubject: | ||
| Enabled: false | ||
| # new configurations since rubocop 1.50.0 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.