Connecting to socket did not work after support for ipv6 in 5.4.0 #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows server to be ":/socket/mysql.sock", host will be empty and "port" (socket) will be path to socket. This will also work with "proxy:/socket/mysql.sock" and host will be "proxy"
magnusvin
force-pushed
the
patch-1
branch
6 times, most recently
from
3bd2a81 to
51b8992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After update to 5.4.0 connecting to ":/socket/mysql.sock" did not work. Since host always is specified along with socket it does not work. I have made a change to "host_port" so unix socket is splitted to port section instead of to host.
I then make a check if host is empty and does not include host in dsn if empty