fix gha error logic

Author: vslavik

.github/workflows/build-ota-updates.yml

@@ -44,3 +44,9 @@ jobs:
         else
           echo "::notice title=No updates::No translations were updated."
         fi
+    - name: Check for PO compilation errors
+      run: |
+        if [ -f ota-had-errors ]; then
+          echo "::warning::Some strings were removed from OTA translations due to errors."
+          exit 1
+        fi

scripts/build-ota-translations.sh

@@ -13,7 +13,7 @@ trap finish EXIT
 recode-sr-latin <locales/sr.po >locales/sr@latin.po
 
 # check PO files for errors and fix the ones that won't compile:
-uv run scripts/check-translations.py --github --remove-errors
+uv run scripts/check-translations.py --github --remove-errors || touch ota-had-errors
 # double-check that fixes were correct:
 for po in locales/*.po ; do
     msgfmt -c -o /dev/null $po

scripts/check-translations.py

@@ -93,7 +93,7 @@ def main():
 
     po_files = glob.glob('locales/*.po')
     status = check_translations(po_files, args.github, args.remove_errors)
-    if not status and not args.remove_errors:
+    if not status:
         sys.exit(1)