MAI-56: drop cache:'npm' and bump node 20→24 in generated GH Actions bump workflow#18
Merged
Merged
Conversation
- remove cache: 'npm' from generated setup-node step so workflow runs on projects without a Node lock file - bump generated node-version 20 to 24 (node 20 deprecated on GitHub runners)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://velvary.atlassian.net/browse/MAI-56
Problem
maiass --create-gh-actiongenerated.github/workflows/maiass-version-bump.ymlwith anactions/setup-node@v4step that setcache: 'npm'. For projects with no Node lock file (e.g. WordPress/PHP plugins),setup-nodefails before maiass runs:The generated workflow only does
npm install -g maiass, which needs no project-level npm cache, so the cache was pointless. The generatednode-version: '20'is also deprecated on GitHub runners.Fix
In the template
templates/ci/github-version-bump.yml(consumed bylib/ci-templates.jscreateGithubAction()):cache: 'npm'from the generatedsetup-nodestep (added an explanatory comment).node-versionfrom'20'to'24'.Verification
maiass --create-gh-actionin a clean temp dir → generated workflow now hasnode-version: '24'and nocache:key.node maiass.mjs --helpworks.Scope note
Only the generated template was changed. This repo's own
.github/workflows/version-bump.ymlmirrors the template but has a realpackage-lock.json, socache: 'npm'works there — left untouched, out of scope for this ticket.🤖 Generated with Claude Code