Fixed parsing of length of meta_command in midi files #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please rebase your PR on top of #109 fix. |
vstinner
approved these changes
Jan 5, 2026
Owner
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but the CI fails, you need to rebase your PR.
It should be a "variable-length quantity" not necessarily a single byte. For example Copytright info of len greater than 0x80 are not properly parsed befoer this fix
Owner
|
Merged. Thanks for your contribution! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be a "variable-length quantity" not necessarily a single byte.
For example Copytright info of len greater than 0x80 are not properly parsed befoer this fix