fix: default address not persisting when creating new address - #208
Open
eltonleaocadastra wants to merge 1 commit into
Open
fix: default address not persisting when creating new address#208eltonleaocadastra wants to merge 1 commit into
eltonleaocadastra wants to merge 1 commit into
Conversation
When creating a new address in the cost center details page with the 'default address' checkbox enabled, the new address was being appended to the end of the addresses array. Since the backend considers the first address in the array as the default, the previously existing address remained as default. This fix places the new address at the beginning of the array when the 'default' checkbox is enabled, ensuring the backend correctly persists it as the default address.
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Author
|
Patch |
Author
|
There's nothing new to document 🤔 |
Author
|
@vtex-apps/b2b Could someone please check the boxes for Patch version and "There's nothing new to document"? As an external contributor I don't have permission to edit the bot comments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
When creating a new address in the cost center details storefront page (
/account#/cost-center/{id}) with the "default address" checkbox enabled, the new address is not being set as default after saving.Root Cause: The new address was being appended to the end of the addresses array: