Skip to content

feat(delivery-promise): register pickup selector presence - #34

Open
hiagolcm wants to merge 1 commit into
mainfrom
feat/unify-delivery-promise-facets-visibility
Open

feat(delivery-promise): register pickup selector presence#34
hiagolcm wants to merge 1 commit into
mainfrom
feat/unify-delivery-promise-facets-visibility

Conversation

@hiagolcm

@hiagolcm hiagolcm commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary (written by human)

The delivery promise related facet will only be shown in two situations

  1. Merchant deliberately set the showDeliveryPromiseFacets to true
  2. or, there is at least one delivery-promise-component block (shopper-location-setter, pickup-point-selector or shipping-method-selector) rendered in the page

This PR allows the pickup-point-selector to be seen in the search-result component trough the uiRegistry. shopper-location-setter and pickup-point-selector were already in the uiRegistry

Changes

  • add pickupPoint to the shared DeliveryPromiseContext UI registry
  • add register and unregister actions for pickup-point block presence
  • register pickup-point-selector on mount and remove it on unmount
  • preserve existing shopper-location and shipping-method registry entries

Tests

  • added reducer coverage for pickup-point registration and cleanup
  • full React suite: 178 tests passed
  • make lint: passed with no errors

Assumptions

  • pickup-point-selector is optional, so its registry metadata uses required: false

Spec

Coordinated PR

Expose pickup-point-selector in the shared UI registry so consumers can detect any mounted delivery-promise block.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Jul 16, 2026

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

vtex-io-docs-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants