feat(delivery-promise): register pickup selector presence - #34
Open
hiagolcm wants to merge 1 commit into
Open
Conversation
Expose pickup-point-selector in the shared UI registry so consumers can detect any mounted delivery-promise block. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
ArthurFerrao
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (written by human)
The delivery promise related facet will only be shown in two situations
showDeliveryPromiseFacetsto trueThis PR allows the pickup-point-selector to be seen in the search-result component trough the uiRegistry. shopper-location-setter and pickup-point-selector were already in the uiRegistry
Changes
pickupPointto the sharedDeliveryPromiseContextUI registrypickup-point-selectoron mount and remove it on unmountTests
make lint: passed with no errorsAssumptions
pickup-point-selectoris optional, so its registry metadata usesrequired: falseSpec
Coordinated PR