Skip to content

Conversation

@carlosviniciusananias
Copy link

What is the purpose of this pull request?
The main objective of this request is to enable shopkeepers to load third-party scripts outside the main thread with the help of the partytown library and the vtex application.

What problem is this solving?
Page loading time, considering core web vitals metrics.

How should this be manually tested?
Run the app in any development workspace, configure the google tag manager identifier, select partytown and save.
Just go to the website and make sure the type is text/partytown and then perform load tests.

Screenshots or example usage


Types of changes
New feature (a non-breaking change which adds functionality)

Observation:
In tests carried out, an evolution of 20 points of performance and improvement in fcp, tti, tbt and lcp was noticed.

…de the main thread and validations for use debugging tag assistant
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 1, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

carlosananias

This comment was marked as resolved.

Copy link
Contributor

@danzanzini danzanzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carlosviniciusananias. Thanks for the great contribution.

I've requested one change regarding the setting type.

Copy link
Contributor

@danzanzini danzanzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added some suggestion to the documentation :)

@carlosviniciusananias
Copy link
Author

@danzanzini Pull request updated with your recommendations.

Copy link
Contributor

@danzanzini danzanzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done. Just some small adjustments and we'll be ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants