Skip to content

Conversation

@salesfelipe
Copy link
Contributor

@salesfelipe salesfelipe commented Jan 17, 2025

What problem is this solving?

  • Updating our service to the latest node builder.
  • Update our dev setup, dev packages and so on.

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@salesfelipe salesfelipe added the enhancement New feature or request label Jan 17, 2025
@salesfelipe salesfelipe self-assigned this Jan 17, 2025
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jan 17, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 17, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

"description": "GraphQL resolvers for the VTEX API for the catalog and orders.",
"credentialType": "absolute",
"builders": {
"node": "6.x",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change

@salesfelipe salesfelipe requested a review from a team January 17, 2025 19:36
})

describe('tests related to the productSearch query', () => {
describe.skip('tests related to the productSearch query', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skiping theese tests because they were already broken and to fix it I would need to make this PR even bigger...

@salesfelipe salesfelipe merged commit eb06ba6 into v1.x Jan 22, 2025
8 of 12 checks passed
@salesfelipe salesfelipe deleted the chore/update-node branch January 22, 2025 14:58
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jan 22, 2025

Your PR has been merged! App is being published. 🚀
Version 1.72.0 → 1.73.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants