Skip to content

Optimize local cache and Change Min number of replicas #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Optimize local cache and Change Min number of replicas #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd7c0cd
Change minReplicas to 5
salesfelipe Jan 29, 2025
d814c45
Change cache configs to better reflect the actual usage
salesfelipe Jan 29, 2025
88aebf3
Update changelog
salesfelipe Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Changed

- Set minimum replicas to 5.
- Increased search cache size.
- Reduced apps cache size.

## [1.74.0] - 2025-01-29

### Changed
Expand Down
4 changes: 2 additions & 2 deletions node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ const NINE_SECONDS_MS = 9 * 1000

// Segments are small and immutable.
const segmentCache = new LRUCache<string, Cached>({ max: 1000 })
const searchCache = new LRUCache<string, Cached>({ max: 3000 })
const searchCache = new LRUCache<string, Cached>({ max: 6000 })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we recently made the pod bigger we can safely increase the size of this cache because we have a lot of room to grow.

const messagesCache = new LRUCache<string, Cached>({ max: 3000 })
const vbaseCache = new LRUCache<string, Cached>({ max: 3000 })
const appsCache = new LRUCache<string, Cached>({ max: 3000 })
const appsCache = new LRUCache<string, Cached>({ max: 1500 })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have no disposed items, we can try to reduce the size of it...


metrics.trackCache('segment', segmentCache)
metrics.trackCache('search', searchCache)
Expand Down
2 changes: 1 addition & 1 deletion node/service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"ttl": 60,
"timeout": 12,
"minReplicas": 10,
"minReplicas": 5,
"maxReplicas": 250,
"workers": 2,
"routes": {
Expand Down
Loading