Skip to content

Conversation

@salesfelipe
Copy link
Contributor

@salesfelipe salesfelipe commented Sep 17, 2025

What problem is this solving?

  • Using real production traffic to test the new service.

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@salesfelipe salesfelipe requested a review from a team as a code owner September 17, 2025 21:05
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 17, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 17, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@chrsmutti chrsmutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

intsch.fetchAutocompleteSuggestions({
query,
}),
ctx.vtex.production ? 1 : 100,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement: should only send 1% of the traffic from Prod to the new API.

@salesfelipe salesfelipe self-assigned this Sep 22, 2025
@salesfelipe salesfelipe added the enhancement New feature or request label Sep 22, 2025
@salesfelipe salesfelipe changed the title Feature/new is api Send shadow autocomplete shadow traffic to the new EKS Api. Sep 22, 2025
}

if (!hasError1) {
return result1 as T
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still using the results from the I/O app

expect(response).toEqual(result)
})

it('should still function if the new client fails', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validating that the errors on the new API shouldn't block the production request

expect(ctx.vtex.logger.error).not.toHaveBeenCalled()
})

it('should log if the results are different', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validating that the log is working

@salesfelipe salesfelipe changed the title Send shadow autocomplete shadow traffic to the new EKS Api. Send autocomplete shadow traffic to the new EKS Api. Sep 22, 2025
Copy link
Contributor

@chrsmutti chrsmutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@salesfelipe salesfelipe merged commit aee5647 into v1.x Sep 23, 2025
6 of 10 checks passed
@salesfelipe salesfelipe deleted the feature/newIsApi branch September 23, 2025 12:58
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 23, 2025

Your PR has been merged! App is being published. 🚀
Version 1.76.0 → 1.77.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants