Skip to content

Feature/shipping facets as radio #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ArthurFerrao
Copy link
Contributor

What problem is this solving?

Add radio buttons to the shipping filter.
Task TIS-90

How to test it?

Use the shipping filter on the PLP.

Workspace

Screenshots or example usage:

Gravacao.de.Tela.2025-04-09.as.15.22.05.mov

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@ArthurFerrao ArthurFerrao requested a review from hiagolcm April 9, 2025 18:26
@ArthurFerrao ArthurFerrao self-assigned this Apr 9, 2025
@ArthurFerrao ArthurFerrao requested review from a team as code owners April 9, 2025 18:26
@ArthurFerrao ArthurFerrao requested review from gabpaladino, RodrigoTadeuF and leo-prange-vtex and removed request for a team April 9, 2025 18:26
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 9, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@ArthurFerrao ArthurFerrao force-pushed the feature/shipping-facets-as-radio branch from f0e4e4f to dc56dff Compare April 9, 2025 18:29
Copy link

github-actions bot commented Apr 9, 2025

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.
Warnings
⚠️

👀 The size of this pull request seems relatively large (>420 modifications). Consider splitting it into smaller pull requests to help make reviews easier and faster.

Generated by 🚫 dangerJS against dc56dff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants