Skip to content

Conversation

@MatheusLealv
Copy link
Contributor

@MatheusLealv MatheusLealv commented Dec 8, 2025

This reverts commit da70f18, reversing changes made to dd5a90b.

We are facing some issues for displaying Ads for some publishers (INC-4666)

The ads are not correctly being displayed for some IO publishers, we are rolling it back to the previous version while we investigate the root cause for this problem.

What problem is this solving?

How to test it?

[Workspace](Link goes here!)

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

This reverts commit da70f18, reversing
changes made to dd5a90b.
@MatheusLealv MatheusLealv requested review from a team as code owners December 8, 2025 18:55
@MatheusLealv MatheusLealv requested review from RodrigoTadeuF, leo-prange-vtex and vsseixaso and removed request for a team December 8, 2025 18:55
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 8, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 8, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Fails
🚫

We follow keepachangelog standards.

Please, add a section to your changelog entry. Example:

 ## [Unreleased]

+ ### Fixed
 - Issue with image sizing in the SKU Selector.

You can use one of the following sections:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.
🚫

Please remove the line ## [3.142.0] - 2025-12-04 [YANKED] from CHANGELOG.md
This will be automatically added once this PR is merged.

Generated by 🚫 dangerJS against a5059f8

Copy link
Contributor

@chrsmutti chrsmutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatheusLealv MatheusLealv merged commit bc18f9f into master Dec 8, 2025
9 of 10 checks passed
@MatheusLealv MatheusLealv deleted the chore/revert-ads-sdk-pr branch December 8, 2025 19:06
MatheusLealv added a commit that referenced this pull request Dec 9, 2025
MatheusLealv added a commit that referenced this pull request Dec 15, 2025
Revert "Merge pull request #730 from vtex-apps/chore/revert-ads-sdk-pr"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants