Fix: filter ads from product count in fetchMore calculation #733
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusLealv
requested review from
amandascm,
brenonovelli,
diegopgcabral,
fltiago,
luarakerlen,
rodorgas and
rogeralbinoi
MatheusLealv
requested review from
gabpaladino,
vmourac-vtex and
vsseixaso
and removed request for
a team
Contributor
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
emersonme
approved these changes
Jan 9, 2026
rogeralbinoi
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fix is related to this report:
Fixes "Load More" button not loading additional organic products when ads are present.
Problem
When ads are merged into search results, the product array includes both ads and organic products. This count was being passed to
useFetchMore, causing Apollo to calculate incorrect pagination offsets.Example: 3 ads + 20 organic = 23 products
Solution
Filter out ads before passing the product list to
useFetchMore, ensuring pagination uses only organic product count.Changes
react/FetchMore.js: Filteradvertisementproducts before passing touseFetchMoreHow to test it?
Follow this video to try to reproduce the issue: https://drive.google.com/file/d/1fdDjY9wLAlVXEfM3x9YwOVdMIsgxmPGC/view
workspace with the fix applied by
vtex link: https://leal--supernossoio.myvtex.com/merceariaHow does this PR make you feel? 🔗