fix: added prefix to tailwind variables#13
Open
NicolaiHorlacher wants to merge 1 commit intovue-a11y:masterfrom
Open
fix: added prefix to tailwind variables#13NicolaiHorlacher wants to merge 1 commit intovue-a11y:masterfrom
NicolaiHorlacher wants to merge 1 commit intovue-a11y:masterfrom
Conversation
Member
|
Thanks @NicolaiHorlacher @lucasferreiralimax do you want to merge and publish? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed an issue with this package.
Although a prefix is used for the internal tailwind classes, it does not apply to tailwind css variables.
So these tailwind variables can override variables in projects where this package is used.
Unfortunately tailwind does not have a setting for css variables prefixes, so I implemented this workaround:
tailwindlabs/tailwindcss#10697
For example:
--tw-bg-opacitygets renamed to--va-tw-bg-opacitywith this changes.I had to update the
postcsspackages so that the project compiles with a current node version.