Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restrict duplicated imports, support Vue SFC for eslint #10165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: restrict duplicated imports, support Vue SFC for eslint #10165

wants to merge 1 commit into from

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Jan 20, 2024 •
edited
Loading

  • no duplicated imports
  • lint for Vue SFC files

Only a few files are changed, I think the PR can be merged as a patch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 91.1 kB 34.6 kB 31.2 kB
vue.global.prod.js 148 kB 53.9 kB 48.2 kB

Usages

Name Size Gzip Brotli
createApp 51.1 kB 20 kB 18.2 kB
createSSRApp 54.5 kB 21.4 kB 19.4 kB
defineCustomElement 53.4 kB 20.8 kB 18.9 kB
overall 64.9 kB 25 kB 22.7 kB

@sxzz sxzz requested a review from yyx990803 January 20, 2024 16:16
@sxzz sxzz force-pushed the chore/eslint-imports branch 2 times, most recently from 8494efc to 684c83f Compare January 29, 2024 18:32
@sxzz sxzz force-pushed the chore/eslint-imports branch from 684c83f to 12a1763 Compare February 11, 2024 12:46
@sxzz sxzz force-pushed the chore/eslint-imports branch from 12a1763 to 99e6af3 Compare May 30, 2024 13:28
@haoqunjiang haoqunjiang added 🧹 p1-chore Priority 1: this doesn't change code behavior. ready for review This PR requires more reviews labels May 31, 2024
@sxzz sxzz force-pushed the chore/eslint-imports branch from 99e6af3 to 0f3725b Compare June 4, 2024 18:06
@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 deleted the chore/eslint-imports branch October 21, 2024 07:35
@edison1105 edison1105 restored the chore/eslint-imports branch October 21, 2024 08:27
@edison1105 edison1105 reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready for review This PR requires more reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxzz @haoqunjiang @edison1105