Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Teleport): nested teleport should use parent css vars #11023

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(Teleport): nested teleport should use parent css vars #11023

wants to merge 6 commits into from

Conversation

linzhe141
Copy link
Contributor

close #11022

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 91.3 kB (+508 B) 34.7 kB (+131 B) 31.2 kB (+111 B)
vue.global.prod.js 148 kB (+508 B) 53.9 kB (+135 B) 48.1 kB (+145 B)

Usages

Name Size Gzip Brotli
createApp 51 kB (+222 B) 20 kB (+77 B) 18.2 kB (+45 B)
createSSRApp 54.4 kB (+226 B) 21.3 kB (+60 B) 19.4 kB (+76 B)
defineCustomElement 53.3 kB (+222 B) 20.7 kB (+77 B) 18.8 kB (+20 B)
overall 64.8 kB (+222 B) 25 kB (+77 B) 22.6 kB (+54 B)

@edison1105
Copy link
Member

When the slot does not use style vars, should avoid changing the dom.
image

@linzhe141
Copy link
Contributor Author

linzhe141 commented May 29, 2024 •
edited
Loading

When the slot does not use style vars, should avoid changing the dom. image

When the Teleport does not use style vars, it alse changes the dom. So I think this is ok

image

@Rusinas
Copy link

Rusinas commented Jun 16, 2024

Is there a chance to merge it soon? 👉👈

@Rusinas
Copy link

Rusinas commented Aug 13, 2024

@yyx990803 I beg You 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔩 p2-edge-case scope: teleport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-bind() in CSS + Teleport doesn't work (another edge case)
4 participants
@linzhe141 @edison1105 @Rusinas @haoqunjiang