fix: When the app is unmounted, the onMounted of suspense in Transition should not be called

[linzhe141]

close #11037

[edison1105]

• The afterLeave here is meant to render page2 to the container after the transition of page1 has ended. This afterLeave only needs to be executed once. Therefore, I believe the correct fix should be:

activeBranch!.transition!.afterLeave = () => {
  // ....

  // remove afterLeave
  activeBranch!.transition!.afterLeave = undefined
}

• The test case passes without your PR.

[edison1105]

@linzhe141
Hi, The test case passes without your PR.
Could you please check it?

[linzhe141]

@linzhe141 Hi, The test case passes without your PR. Could you please check it?

3.4.27 playground

3.4.28 playground

my bad, and in version 3.4.28, it has been fixed

[edison1105]

@linzhe141
I don't think the underlying problem is fixed. The afterLeave function still executes during app unmounting, which should be avoided.

[linzhe141]

@linzhe141 I don't think the underlying problem is fixed. The afterLeave function still executes during app unmounting, which should be avoided.

Thanks for your review, I will look into this issue again.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	100 kB (+31 B)	38 kB (+6 B)	34.2 kB (+28 B)
vue.global.prod.js	159 kB (+31 B)	57.9 kB (+5 B)	51.5 kB (+32 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.9 kB	18.3 kB	16.7 kB
createApp	55 kB	21.3 kB	19.4 kB
createSSRApp	59 kB	23 kB	20.9 kB
defineCustomElement	59.8 kB	22.8 kB	20.8 kB
overall	68.7 kB (+31 B)	26.4 kB (+7 B)	24 kB (+15 B)

[netlify]

❌ Deploy Preview for vue-next-template-explorer failed.

Name	Link
🔨 Latest commit	9f8be34
🔍 Latest deploy log	https://app.netlify.com/sites/vue-next-template-explorer/deploys/6721fb636a4dce00082b0cae

[pkg-pr-new]

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11059

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11059

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11059

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11059

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11059

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11059

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11059

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11059

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11059

vue

pnpm add https://pkg.pr.new/vue@11059

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11059

commit: 5a62284

[netlify]

❌ Deploy Preview for vue-sfc-playground failed.

Name	Link
🔨 Latest commit	7e68aeb
🔍 Latest deploy log	https://app.netlify.com/sites/vue-sfc-playground/deploys/6721fb2b55ad8d0008b0ecdc

[netlify]

❌ Deploy Preview for vue-sfc-playground failed.

Name	Link
🔨 Latest commit	9f8be34
🔍 Latest deploy log	https://app.netlify.com/sites/vue-sfc-playground/deploys/6721fb6355ad8d0008b10ec5