Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types/runtime-dom): correct boolean attributes type definitions #12736

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inottn
Copy link
Contributor

@inottn inottn commented Jan 18, 2025

In HTML, setting a boolean attribute to the string "false" is invalid. Browsers will treat any string value as true.

This issue was introduced by #3776. Based on the description, it was intended to replace only boolean | 'false' | 'true' with Booleanish, but it actually replaced all boolean types with Booleanish as well.

For reference, here's the relevant React type definitions. You can see that boolean and Booleanish are distinct types.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.2 kB 16.6 kB
createApp 54.3 kB 21.2 kB 19.3 kB
createSSRApp 58.5 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.8 kB 20.7 kB
overall 68.4 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Jan 18, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12736

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12736

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12736

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12736

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12736

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12736

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12736

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12736

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12736

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12736

vue

npm i https://pkg.pr.new/vue@12736

commit: 7464ddd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant