-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsx): add undefined to optional properties #12771
Open
iamandrewluca
wants to merge
3
commits into
vuejs:main
Choose a base branch
from
iamandrewluca:fix/runtime-dom-optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+653
−623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c90aba2
to
cf3b819
Compare
cf3b819
to
fa1e744
Compare
This was referenced Feb 5, 2025
Size ReportBundles
Usages
|
@vue/compiler-ssr
@vue/compiler-core
@vue/reactivity
@vue/runtime-core
@vue/compiler-dom
@vue/runtime-dom
@vue/compiler-sfc
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
LGTM |
jh-leong
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
ready to merge
The PR is ready to be merged.
scope: types
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6068
Allow TypeScript projects that have
exactOptionalPropertyTypes
option enabled to be able to pass explicit props with a value ofundefined
https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes
Let's take for example React:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b30cd2bf71cdef25085038b4a556211c23c16489/types/react/index.d.ts#L3446-L3729
Checklist:
any | undefined
undefined | undefined
I advise reviewing one commit at a time.
Images
"exactOptionalPropertyTypes": false
"exactOptionalPropertyTypes": true
"exactOptionalPropertyTypes": true
and fixedsrc?: string | undefined
Related:
Links: