fix(vapor): infer component multi-root metadata from SFC templates for hydration#14530
Open
edison1105 wants to merge 26 commits intominorfrom
Open
fix(vapor): infer component multi-root metadata from SFC templates for hydration#14530edison1105 wants to merge 26 commits intominorfrom
edison1105 wants to merge 26 commits intominorfrom
Conversation
… the container's first child
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Size ReportBundles
Usages
|
…uce consumeFragmentAnchor utility
…Fragment with trailing sibling
…Shape and updating related logic
…tionNode and updating fragment handling
…g in hydration logic
…de usage and removing obsolete functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Vapor hydration consume SSR fragment starts more precisely by adding explicit structural metadata from the compiler instead of relying on runtime heuristics.
On the compiler side, Vapor SFCs now receive __multiRoot metadata, and createIf codegen now carries blockShape so each branch can describe whether it owns a fragment wrapper. On the runtime side, Vapor hydration uses this metadata to determine whether the current belongs to the current component / v-if branch and can be consumed immediately during creation, which fixes several nested multi-root and interop hydration edge cases.