Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): execute directive lifecycle hooks when unmount theSingleRoot in DEV mode. #5428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Feb 15, 2022

fix: #5407

@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 4cb587f

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/620b23308317900007328b73

😎 Browse the preview: https://deploy-preview-5428--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 4cb587f

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/620b233003c12400080b325e

😎 Browse the preview: https://deploy-preview-5428--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 4cb587f

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620b2330f08d64000731c8a7

😎 Browse the preview: https://deploy-preview-5428--vue-next-template-explorer.netlify.app

// update may be null if a component is unmounted before its async
// setup has resolved.
if (update) {
// so that scheduler will no longer invoke it
update.active = false

if (
__DEV__ &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not work if keep comments in the production build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Directive hooks are inconsistent for components with comment nodes
2 participants