Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Using interface give defineComponent type #5753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

4xii
Copy link
Contributor

@4xii 4xii commented Apr 19, 2022

wecom-temp-b0dcbf976841cb9f401dd513f4de253f
vue2.6的options类型issus#12427
该issus再defineComponent也同样存在,这里更改了defineComponent的范型如下
image
使得在defineComponent传入option的定义即可,而无需一个个传入data,methods等类型

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 5644e2c
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/625e9a0daf26020008715efc
😎 Deploy Preview https://deploy-preview-5753--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 5644e2c
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/625e9a0d346a4e000977ae40
😎 Deploy Preview https://deploy-preview-5753--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 5644e2c
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/625e9a0da804fc0009347ad2

@edison1105
Copy link
Member

the test case should be placed in packages-private/dts-test/component.test-d.ts
I am unsure if this PR is worthwhile since options API is not recommended by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants