test(reactivity): 100% effectScope coverage #7297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test(reactivity): 100% effectScope coverage
| @@ -222,7 +222,7 @@ describe('reactivity/effect/scope', () => { | |||
|
|
|||
| it('should dereference child scope from parent scope after stopping child scope (no memleaks)', () => { | |||
| const parent = new EffectScope() | |||
| const child = parent.run(() => new EffectScope())! | |||
| const [child] = parent.run(() => [new EffectScope(), new EffectScope()])! | |||
There was a problem hiding this comment.
I think it'd be better to add a new test for this, rather than modifying the existing test.
In effectScope.ts, there's this if check:
if (last && last !== this) {That line is only hit once by the tests. Currently it evaluates to false. The change proposed here would switch that, so it evaluates to true. That increases the line coverage, but it's still only testing one of the two branches of the if. Either way there's a chunk of code that could be removed and the tests would still pass.
For example, imagine that if check were changed to this:
if (last) {That would be incorrect and the existing test would catch that, but the new test would still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(reactivity): 100% effectScope coverage