Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): compilation of slot v-if/else when preserve whitespace #9448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(compiler-core): compilation of slot v-if/else when preserve whitespace #9448

wants to merge 1 commit into from

Conversation

pikax
Copy link
Member

@pikax pikax commented Oct 20, 2023

closes #6063
based on #6124

Not exposing the whitespace option to the context because I don't think

// pseudo-node
SlotNode(vIf)
TextNode('')
SlotNode(vElse)

Is possible without the whitespace preserve, since it check for text content to be empty

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB 32.7 kB 29.5 kB
vue.global.prod.js 132 kB (+58 B) 49.4 kB (+14 B) 44.4 kB (-8 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 50.7 kB 20 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.5 kB

@pikax pikax changed the title fix(compiler-core): compilation of slot v-if/else fix(compiler-core): compilation of slot v-if/else when preserve whitespace Oct 20, 2023
@KaloyanYosifov
Copy link

Any update on this?

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Oct 9, 2024
@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 deleted the pikax/fix_perserve_whitespace branch October 21, 2024 07:37
@edison1105 edison1105 restored the pikax/fix_perserve_whitespace branch October 21, 2024 08:12
@edison1105 edison1105 reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔩 p2-edge-case ready to merge The PR is ready to be merged. scope: compiler
Projects
Issue / PR Management
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using whitespace "preserve" wont compile v-if/v-else using same slot name
3 participants
@pikax @KaloyanYosifov @edison1105