feat!: use a giant multiselect instead of individual toggles for features #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures As we are adding more features, the number of toggles is getting out of hand. A multiselect could save a few keystrokes for most users. I also take this opportunity to change the prompts library to `@clack/prompts`. The color library is changed to `picocolors`. IMO `kleur` is still the smaller library because of treeshaking. But `@clack/prompts` already comes with `picocolors` as a dependency, so by not adding `kleur`, we save a few bytes. This is a proof-of-concept change. I haven't put much consideration into the code style yet. Nor have I updated the i18n messages. I will do that if this change is accepted. See the result in a screen recording: [](https://asciinema.org/a/lPaZSGz9LTd7mcWZeJAZxerhx)
… ci] Still much work to do. But it's acdceptable for now.
cexbrayat
approved these changes
Feb 18, 2025
btea
reviewed
Feb 19, 2025
| @@ -45,19 +45,19 @@ | |||
| } | |||
| }, | |||
| "needsEslint": { | |||
| "message": "Add ESLint for code quality?", | |||
| "message": "Add ESLint for code quality", | |||
](https://asciinema.org/a/lPaZSGz9LTd7mcWZeJAZxerhx){kind=link}
There was a problem hiding this comment.
This is no longer a question. Can the Yes in the following options be removed? Otherwise, it looks a bit strange that both options contain Yes.
And the negative option has been removed, the negative attribute below can also be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are adding more features, the number of toggles is getting out of hand. A multiselect could save a few keystrokes for most users.
I also take this opportunity to change the prompts library to
@clack/prompts.(For context:
create-astro,sv,create-preact,create-solid,create-qwikall use@clack/prompts, whilecreate-vite&create-next-appuseprompts)The color library is changed to
picocolors. IMOkleuris still the smaller library because of treeshaking. But@clack/promptsalready comes withpicocolorsas a dependency, so by not addingkleur, we save a few bytes.This is a proof-of-concept PR. I haven't put much consideration into the code style yet. Nor have I updated the i18n messages. I will do that if this change is accepted.
See the result in a screen recording:
