Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: required node version #2756

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

Yordan-Ramchev
Copy link
Contributor

@Yordan-Ramchev Yordan-Ramchev commented Mar 18, 2024

Description of Problem

vue-cli relies on a more up-to-date Node.js version since v3.10 (now it's using parseArgs from node:util):
https://github.com/vuejs/create-vue/releases/tag/v3.10.0
vuejs/create-vue#469

Proposed Solution

Update required node version to greater than 18.11

Additional Information

Based on Node.js changelog, the value should be 18.11 https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2022-10-13-version-18110-current-danielleadams

### Description
Update required node version to greater than 18.13

### Notes for Reviewers

As vue-cli rely on a more up to date nodejs version to parse args since v3.10:
- https://github.com/vuejs/create-vue/releases/tag/v3.10.0
- vuejs/create-vue#469

Based on nodejs changelog the value should be 18.13
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-01-05-version-18130-hydrogen-lts-danielleadams
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 839d83c
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/65f957414938300008c2e7d4
😎 Deploy Preview https://deploy-preview-2756--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Yordan-Ramchev Yordan-Ramchev changed the title Update quick-start.md update: required node version Mar 18, 2024
@brc-dd
Copy link
Member

brc-dd commented Mar 18, 2024

It should work fine on node v18.3 or above.

@NataliaTepluhina
Copy link
Member

Updated to recommended version 18.3

@NataliaTepluhina NataliaTepluhina merged commit 91339e6 into vuejs:main Mar 19, 2024
4 of 5 checks passed
@Yordan-Ramchev Yordan-Ramchev deleted the patch-1 branch March 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants