Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add "Kevin Deng" to core member #2760

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ubugeeei
Copy link
Member

Description of Problem

Kevin Deng is an important figure in the Vue.js community!
He has made significant contributions to projects such as vuejs/core, Vue Macros, and VueUse.
Recently, he has been active as the lead of vuejs/core-vapor.
He is definitely someone who should be featured in the documentation! 😄

Proposed Solution

Document updation!

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 0f349a0
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/65fda97c4e93330008e57588
😎 Deploy Preview https://deploy-preview-2760--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ubugeeei
Copy link
Member Author

@sxzz
Please let me know if there are any issues!

@brc-dd brc-dd requested a review from sxzz March 22, 2024 04:36
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks bro. But I think I should be added to the end.

@ubugeeei ubugeeei force-pushed the update-members-core-kevin branch from 79bb40e to bf6d2bd Compare March 22, 2024 15:28
@ubugeeei
Copy link
Member Author

Ok.... fixed!

@brc-dd brc-dd merged commit 1731ec5 into vuejs:main Mar 22, 2024
5 checks passed
@brc-dd
Copy link
Member

brc-dd commented Mar 22, 2024

@danielkellyio Hey, can that https://vueschool.io/banner.js script set --vt-banner-height variable on :root when a banner is shown. Currently some of our code needs that to be set:

image

without banner:

image

(notice the left pannel)

brc-dd added a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants