Skip to content

Fix todomvc example: prefix todomvc mounted hook with "vue:" - #241

Closed
ethmcc wants to merge 1 commit into
vuejs:mainfrom
ethmcc:patch-1
Closed

Fix todomvc example: prefix todomvc mounted hook with "vue:"#241
ethmcc wants to merge 1 commit into
vuejs:mainfrom
ethmcc:patch-1

Conversation

@ethmcc

@ethmcc ethmcc commented Aug 31, 2024

Copy link
Copy Markdown

The todomvc example has a use of the @mounted hook, triggering an error:

mounted and unmounted hooks now need to be prefixed with vue: - use @vue:mounted="handler" instead.

I checked for any other stray uses of @mounted or @unmounted in the repo to clean up; there were no other instances.

Fixes error: 

mounted and unmounted hooks now need to be prefixed with vue: - use @VUE:mounted="handler" instead.
@ethmcc

ethmcc commented Aug 31, 2024

Copy link
Copy Markdown
Author

Closing because I looked through the open PRs and noticed that fixes for this and other examples were already proposed in: #224.

Looks like this bug first noted in #170, over two years ago, but nothing has been merged since months before that.

@ethmcc ethmcc closed this Aug 31, 2024
@jikkuatwork

Copy link
Copy Markdown

Thats sad! Wish the relevant fixes were addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants