- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.2k
 
fix(devtools): setup the settings panel immediately #2858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
          ✅ Deploy Preview for pinia-playground ready!
 To edit notification comments on pull requests, go to your Netlify site configuration.  | 
    
          ✅ Deploy Preview for pinia-official ready!
 To edit notification comments on pull requests, go to your Netlify site configuration.  | 
    
          
commit:   | 
    
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##               v3    #2858   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          17       17           
  Lines        1381     1381           
  Branches      211      211           
=======================================
  Hits         1260     1260           
  Misses        120      120           
  Partials        1        1           ☔ View full report in Codecov by Sentry.  | 
    
| 
           Is this still needed in the new version?  | 
    
          
 @posva Yes, the option about   | 
    
| 
           I see. I think the fix should be different, registering the plugin once would be better. I will see later on if I can refactor the code for it  | 
    
| 
           I tried fixing this with https://github.com/vuejs/pinia/tree/fix/devtools-setup-once but it seems like the timeline doesn't show up anymore and there are build issues. I don't know if this is a vue devtools regression  | 
    
fix #2818