Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deprecated syntax #2908

Closed

Conversation

andrewvasilchuk
Copy link
Contributor

Updated tests to avoid using the deprecated syntax of the defineStore function.

Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit c9d36df
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/67a8ab32b667340008d595b1

Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit c9d36df
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/67a8ab32e347640008be8dd7

Copy link

pkg-pr-new bot commented Feb 9, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@pinia/nuxt@2908
npm i https://pkg.pr.new/pinia@2908
npm i https://pkg.pr.new/@pinia/testing@2908

commit: c9d36df

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.46%. Comparing base (394f655) to head (c9d36df).
Report is 3 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #2908   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          19       19           
  Lines        1456     1456           
  Branches      227      227           
=======================================
  Hits         1288     1288           
  Misses        167      167           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

posva commented Feb 9, 2025

Thanks! This was already added in the PR for pinia 3

@posva posva closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants