- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.2k
 
feat: expose providePinia to use multiple root stores #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
          Codecov Report
 @@           Coverage Diff           @@
##               v2     #878   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           9        9           
  Lines         376      378    +2     
  Branches      100      100           
=======================================
+ Hits          375      377    +2     
  Partials        1        1           
 Continue to review full report at Codecov. 
  | 
    
| 
           Thanks! I will have to give this more thought as there might be some edge cases with   | 
    
| 
           Is there some way I can help with that?  | 
    
          ✅ Deploy Preview for pinia-official canceled.
  | 
    
| 
           Currently, there are still a few issues: 
 Overall, I think exposing the symbol and letting the user use at their own risk might be a better idea. Otherwise, a proper solution would be a custom pinia similar to the testing one  | 
    
          Codecov Report
 @@           Coverage Diff           @@
##               v2     #878   +/-   ##
=======================================
  Coverage   99.73%   99.74%           
=======================================
  Files           9        9           
  Lines         383      385    +2     
  Branches       97       97           
=======================================
+ Hits          382      384    +2     
  Partials        1        1           
 Continue to review full report at Codecov. 
  | 
    
| 
           @bodograumann would exposing the symbol be enough? I added a couple of tests to explain what I meant. Maybe  There is also a concern about devtools. Right now, they expect no more than one pinia to be created for an app.  | 
    
| 
           I have a hard time wrapping my head around the whole context right now.  | 
    
Implements #870.