fix(#2591): findComponent doesn't not return exposed properties in vm#2715
Open
adamberecz wants to merge 2 commits intovuejs:mainfrom
Open
fix(#2591): findComponent doesn't not return exposed properties in vm#2715adamberecz wants to merge 2 commits intovuejs:mainfrom
findComponent doesn't not return exposed properties in vm#2715adamberecz wants to merge 2 commits intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cexbrayat
requested changes
Sep 30, 2025
Member
cexbrayat
left a comment
There was a problem hiding this comment.
Thank you for looking into it. Would you mind adding a unit test that showcases that the issue no longer exists?
Member
|
Hi @adamberecz Would you mind adding some unit tests to the PR so we can merge it? |
Author
|
I've stumbled upon another issue related to using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After investigating the issue down to
@vue/runtime-coreit appears thatexposeProxyis only set in a script-setup component if it uses at least one directive:https://github.com/vuejs/core/blob/main/packages/runtime-core/src/component.ts#L1187
https://github.com/vuejs/core/blob/main/packages/runtime-core/src/directives.ts#L143
Meaning a component can have an exposed API while
exposeProxyisnull. In this case we can create manually fromexposedwhich essentially has the same effect, because the one created by runtime-core is only different by also proxyingpublicPropertiesMapwhich aren't available anyway.