Skip to content

fix: correct <summary> element behavior #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nn-morishita wants to merge 5 commits into
base: main
Choose a base branch
from
+122 −6
Open

fix: correct <summary> element behavior #2806

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47c12a3
fix: handle summary element correctly
nn-morishita Apr 5, 2026
d23d0a8
fix: preserve visible details/summary behavior
nn-morishita May 4, 2026
edab927
fix: format
nn-morishita May 10, 2026
70ffcba
refactor: enhance isElementVisible with JSDoc and fix test cases
nn-morishita May 14, 2026
44842da
restore isElementVisible hidden check for HTMLElement and remove unre…
nn-morishita May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/utils/isElementVisible.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ function isStyleVisible<T extends Element>(element: T) {
}

function isAttributeVisible<T extends Element>(element: T) {
if (
element.nodeName === 'SUMMARY' &&
element.closest('details')
) {
return true
}
return (
!element.hasAttribute('hidden') &&
(element.nodeName === 'DETAILS' ? element.hasAttribute('open') : true)
Expand All @@ -31,6 +37,6 @@ export function isElementVisible<T extends Element>(element: T): boolean {
element.nodeName !== '#comment' &&
isStyleVisible(element) &&
isAttributeVisible(element) &&
(!element.parentElement || isElementVisible(element.parentElement))
(element.nodeName === 'SUMMARY' || !element.parentElement || isElementVisible(element.parentElement))
)
}
10 changes: 10 additions & 0 deletions tests/isVisible.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,16 @@ describe('isVisible', () => {
})
expect(wrapper.isVisible()).toBe(false)
})
it ('DetailContent should be visible when summary is visible', () => {
const DetailContent = defineComponent({
template: `<details><summary>Summary</summary><div>Content</div></details>`
})

const wrapper = mount(DetailContent)
expect(wrapper.find('summary').isVisible()).toBe(true)
expect(wrapper.find('div').isVisible()).toBe(false)

})
})
})
})
Loading