feat(theme): find best locale match to format last update - #4360
Open
userquin wants to merge 3 commits into
Open
feat(theme): find best locale match to format last update#4360userquin wants to merge 3 commits into
userquin wants to merge 3 commits into
Conversation
brc-dd
reviewed
Nov 12, 2024
userquin
commented
Nov 14, 2024
| <p class="VPLastUpdated"> | ||
| {{ theme.lastUpdated?.text || theme.lastUpdatedText || 'Last updated' }}: | ||
| <time :datetime="isoDatetime">{{ datetime }}</time> | ||
| <time ref="timeRef" :datetime="isoDatetime">{{ datetime }}</time> |
Member
Author
There was a problem hiding this comment.
use lang attr via ref value here instead element ref
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
August 14, 2025 03:45
c5a8428 to
8abbe29
Compare
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
August 20, 2025 14:41
084cf43 to
d3a1567
Compare
brc-dd
force-pushed
the
main
branch
3 times, most recently
from
March 26, 2026 04:26
15a0278 to
09af6c7
Compare
Collaborator
|
Is this still needed with #4935 merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the logic to find the best locale match from
navigator.languagesincluding:es-419forceLocale(per locale) and will returnundefined(current logic) if not foundlangattribute logicIntl.DateTimeFormat().resolvedOptions().localewhen best match not foundWhen testing this PR with Spanish, you should change replace
lang: 'es-CO',withlang: 'es',(using medium for time style, that's why we have the seconds in the screenshots below) in thees.tsmodule.You can add the languages to your browser sorting them (at least on Chrome).
NOTE about using browser/OS default language:
englishpage the text in english => no time lang attr (en,en-GB,en-USshould be present in languages)spanishpage withes-ES=> time lang withes-ESwith proper format HH24 (es-ESshould be be present inlanguages)es-ESafteres-AR=> time lang withes-ARwith proper format AM/PM (es-ESshould be present in languages)pt,jp...) => using default browser/OS language, in my casees-ES=> time lang withes-ESwith proper format HH24 (doesn't matter if I putes-ARbeforees-ES)Linked Issues
Additional Context
Testing Intl.DateTimeFormat script
Spanish translation with es-AR
Spanish translation with es-ES
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.