Skip to content

feat(theme): find best locale match to format last update #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
userquin wants to merge 3 commits into
base: main
Choose a base branch
from
+31 −2
Open

feat(theme): find best locale match to format last update #4360

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d9b59a
feat(theme): find best locale match to format last update
userquin Nov 12, 2024
aa24dcd
chore: return boolean
userquin Nov 12, 2024
3df33a5
chore: add time lang attribute logic
userquin Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/client/theme-default/components/VPDocFooterLastUpdated.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,27 @@ const datetime = ref('')
// set time on mounted hook to avoid hydration mismatch due to
// potential differences in timezones of the server and clients
onMounted(() => {
function findBestLocaleMatch(pageLocale: string): string | undefined {
return navigator.languages.find((userLang) => {
if (pageLocale === userLang)
return pageLocale
Comment thread
brc-dd marked this conversation as resolved.
Outdated

// Edge browser: case for ca-valencia
if (pageLocale === 'ca-valencia' && userLang === 'ca-Es-VALENCIA')
return pageLocale

// add iso-639 support for Latin America
if (userLang.startsWith('es-') && userLang !== 'es-ES' && pageLocale === 'es-419')
return pageLocale

return userLang.startsWith(pageLocale) ? pageLocale : undefined
})
}
watchEffect(() => {
datetime.value = new Intl.DateTimeFormat(
theme.value.lastUpdated?.formatOptions?.forceLocale ? lang.value : undefined,
theme.value.lastUpdated?.formatOptions?.forceLocale
? lang.value
: findBestLocaleMatch(lang.value),
theme.value.lastUpdated?.formatOptions ?? {
dateStyle: 'short',
timeStyle: 'short'
Expand Down