Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components):Local navigation location error #4393

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(components):Local navigation location error #4393

wants to merge 5 commits into from

Conversation

yuxi-ovo
Copy link

fixes #4359

@yuxi-ovo yuxi-ovo mentioned this pull request Nov 29, 2024
Open
4 tasks
@yuxi-ovo
Copy link
Author

yuxi-ovo commented Dec 1, 2024

who can help me

@yuxi-ovo
Copy link
Author

yuxi-ovo commented Dec 4, 2024

@brc-dd

@yuxi-ovo
Copy link
Author

yuxi-ovo commented Jan 5, 2025

111

@yuyinws
Copy link
Contributor

yuyinws commented Jan 14, 2025

I think we should add the has-sidebar class to the top element, then get the left value by CSS selectors.

Example:

vitepress/src/client/theme-default/components/VPContent.vue

Lines 86 to 89 in 3cd3aee

.VPContent.has-sidebar {
margin: var(--vp-layout-top-height, 0px) 0 0;
padding-left: var(--vp-sidebar-width);
}

@yuxi-ovo
Copy link
Author

@yuyinws ok Thank you for your help. Is that right for me？

@yuyinws
Copy link
Contributor

yuyinws commented Jan 17, 2025 •
edited
Loading

Please fix the CI error.

@yuxi-ovo
Copy link
Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local navigation dropdown misplaced without sidebar
2 participants
@yuxi-ovo @yuyinws