-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ci: add emojis to workflow names and improve their security #4693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm not in favor of the emojis. It looks cool and all but feels like overdoing it in CI runs.
release-tag.yml doesn't need write access to issues or PRs.
|
Then if I'm not mistaken, there will be no permissions at all
No, it's better to have it in the root of the project, that's how it's done everywhere Is there any reason to store this file in the |
To avoid cluttering the main view.
GitHub allows storing it at
It doesn't need any permission except to create a release. It probably doesn't even need the checkout step. |
Fixed |
Description
I improved the security of workflows by restricting permissions and credentials, before running
zizmor
to check for problemsI also added emojis to the workflow names because they make navigation much better and it's easier to understand what they do
Tip
The author of this PR can publish a preview release by commenting
/publish
below.