fix(md)!: change behavior of regions in snippets #5014
+336
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
commit: |
its-miroma
changed the title
its-miroma
changed the title
VitePress supports including a part of a file through a VS Code region. However, when multiple regions have the same name, only one is included. The workaround plugin suggested in vuejs#3690 is no longer maintained. [^1] Furthermore, it suffers from a memory leak causing huge RAM usage. [^2] While we at Fabric Docs have forked the plugin [^3] to fix some issues, it still feels fragile. Another problem is having to use two different syntaxes (`<<<` vs `@[]()`) for doing the same thing, causing confusion. Since this feature has been requested by VitePress directly, I don't think there's any point in working on the plugin any further. fix vuejs#3690 [^1]: <fabioaanthony/markdown-it-vuepress-code-snippet-enhanced#7> [^2]: <https://discord.com/channels/507304429255393322/1208846408552030238/1407245292482330695> via <https://discord.fabricmc.net/> [^3]: <https://github.com/IMB11/md-it-enhanced-snippets>
its-miroma
changed the title
Contributor
Author
|
I hope this PR can get some reviews. I'd also want to make the following breaking changes, but possibly for another PR:
|
when a region is not in the source file, instead of including the whole file, warn that the #region was not found in it. fix vuejs#4625 --- `<<<` snippets now also strip out all #region markers: ```file.ts // #region A // #region B console.log("Hello, World!"); // #endregion // #endregion ``` <<< file.ts#A ...does not include "#region B" anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
VitePress supports including a part of a file through a VS Code region. However, when multiple regions have the same name, only one is included.
The workaround plugin suggested in #3690 is no longer maintained. 1 Furthermore, it suffers from a memory leak causing huge RAM usage. 2
While we at Fabric Docs have forked the plugin 3 to fix some issues, it still feels fragile.
Another problem is having to use two different syntaxes (
<<<vs@[]()) for doing the same thing, causing confusion.Since this feature has been requested by VitePress directly, I don't think there's any point in working on the plugin any further.
Linked Issues
fix #3690
fix #4625
Additional Context
Footnotes
https://github.com/fabioaanthony/markdown-it-vuepress-code-snippet-enhanced/issues/7 ↩
https://discord.com/channels/507304429255393322/1208846408552030238/1407245292482330695 via https://discord.fabricmc.net/ ↩
https://github.com/IMB11/md-it-enhanced-snippets ↩