Skip to content

fix: avoid nested sidebar controls#5251

Open
cookesan wants to merge 1 commit into
vuejs:mainfrom
cookesan:sidebar-a11y-controls
Open

fix: avoid nested sidebar controls#5251
cookesan wants to merge 1 commit into
vuejs:mainfrom
cookesan:sidebar-a11y-controls

Conversation

@cookesan

Copy link
Copy Markdown
Contributor

Summary

  • make non-link collapsible sidebar carets decorative so the focused header button no longer contains another button
  • keep linked sidebar groups using the caret as the separate toggle
  • add e2e coverage for the sidebar accessibility regression

Fixes #3517

Checks

  • pnpm -F=tests-e2e test multi-sidebar/index.test.ts
  • pnpm check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

accessibility: interactive controls should not be nested

1 participant