fix(theme): remove invalid role and tabindex from VPSidebarItem wrapper - #5371
Open
jibin7jose wants to merge 1 commit into
Open
fix(theme): remove invalid role and tabindex from VPSidebarItem wrapper#5371jibin7jose wants to merge 1 commit into
jibin7jose wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
VPSidebarItemcomponent generated invalid HTML, which caused W3C validation errors and created an improper accessibility tree.Specifically, the outer wrapper
<div class="item">was being assignedrole="button"andtabindex="0". Because this wrapper contains the heading (h2-h6) and the caret toggle button (<div class="caret" role="button">), it resulted in:h2element being illegally nested inside abutton.button(caret) being illegally nested inside anotherbutton.This PR removes the
roleandtabindexattributes from the outer.itemwrapper (and cleans up the unuseditemRolecomputed property).Linked Issues
fixes #5366
Additional Context
.caretbutton remains the accessible, focusable element for screen readers to toggle the section).Tip
The author can publish a preview release by commenting
/publishafter creating the PR.