fix: use explicit id to merge meta head tags - #5379
Open
shamu45678 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use an explicit
idas the merge key formetahead entries, regardless of attribute order, while preserving the existing first-attribute fallback for entries without anid.This follows the maintainer's latest guidance in #5362. Unlike the closed #5363 approach, it does not special-case
contentorname. It also documents the behavior and adds focused tests for replacement by a shared ID and preservation by unique IDs.Validation:
corepack pnpm lint-stagedcorepack pnpm exec vitest run -r __tests__/unit shared/shared.test.ts(1 file, 2 tests passed)corepack pnpm exec tsc -p __tests__/unit --noEmitLinked Issues
fixes #5362
Additional Context
Entries without an
idretain the current first-attribute deduplication behavior, so this is backward-compatible for existing configurations.